sirius-press/plugins/sirius-press-auth/includes/class-spa-register.php
Silent Mode ddf49a5523 fix(sirius-press): recovering a key is not the same as verifying a signature
Running the fork against a live WordPress found a real hole in registration,
and it is the kind that only shows up when you actually try it.

ECDSA public-key recovery always succeeds. Given any well-formed signature
and any digest it returns a key — just not the signer's, unless the digest is
the one that was signed. The auth flow leaned on that as if a wrong message
would fail. It does not; it quietly yields a stranger's address.

At sign-in this was harmless, because the wrong address matches no account
and the attempt fails. Registration and wallet-linking were another matter:
both took the recovered address and bound it to an account, so a signature
over slightly different text — a challenge copied without its blank line, a
wallet that rewrote the text, a login signature replayed at the registration
form — created an account keyed to an address nobody could sign for. The
person would see "success" and discover the truth the next time they tried to
get in. Wallet-linking was worse still: it would move an existing account onto
a dead address and lock its owner out of their own site.

Both paths now require the address the signer claims and compare it to the
recovered one, which is what verification actually means. Sign-in accepts the
claim when the page sends it and uses it to turn "no account uses that wallet"
into the more useful "that signature is not over the text we asked for".

Also from running it:

URL rewriting mangled every link on a site whose URL carries a port. The
protocol-relative pass matched inside absolute URLs and gave each one a second
scheme, and matching the host without its port left the port stranded as
`//host:8760:8760/`. Local and staging installs would have exported a site of
broken links.

Plain permalinks silently collapse an entire site onto one exported file,
because every post's URL is `/?p=N` and its path is `/`. The queue looks
healthy the whole time. The Publishing screen now says so.

Translations loaded on `plugins_loaded`, which WordPress 6.7 warns about on
every request — the kind of noise that trains people to stop reading logs.

And one deletion: an `is_email()` filter written on the assumption that
WordPress rejects `.invalid` addresses. It does not — `is_email()` validates
syntax, not whether a domain could exist — so the filter never fired. A filter
that appears to relax a rule but does not is worse than no filter, because
someone later reasons from it. The documentation made the same claim and has
been corrected.

Verification added rather than asserted: tests/live.mjs drives a real instance
over HTTP (40 checks), and tests/mock-gateway.mjs answers uploads with the
signature check transcribed from the gateway's own source, so the publishing
path can be exercised without a registered name.
2026-09-21 02:35:32 +02:00

178 lines
6.6 KiB
PHP

<?php
/**
* Creating an account without an email address.
*
* Stock WordPress registration is a two-step dance around a mailbox: you hand
* over an address, it sends you a link, you click it, and the click is the
* proof. The proof here is a signature, which arrives in the same request —
* so registration is one step, and there is no pending state, no confirmation
* link to expire, and no way for a typo'd address to strand an account.
*
* This lives at `wp-login.php?action=sirius_register` rather than replacing
* core's `action=register`, so the plugins work unmodified on a stock
* WordPress too. The core patch in `patches/` is then a two-line redirect
* instead of a rewritten form — which is the whole reason the fork's diff
* against upstream stays small enough to merge security releases into.
*
* @package SiriusPress
*/
defined( 'ABSPATH' ) || exit;
final class SPA_Register {
const ACTION = 'sirius_register';
public static function hooks() {
add_action( 'login_form_' . self::ACTION, array( __CLASS__, 'handle' ) );
add_filter( 'register_url', array( __CLASS__, 'filter_register_url' ) );
// Core's own registration form cannot work here — it requires an email
// address — so send anyone who reaches it to the wallet flow.
add_action( 'login_form_register', array( __CLASS__, 'redirect_core_register' ) );
}
public static function url() {
return add_query_arg( 'action', self::ACTION, wp_login_url() );
}
public static function filter_register_url( $url ) {
return self::url();
}
public static function redirect_core_register() {
wp_safe_redirect( self::url() );
exit;
}
/** Render and process the registration screen. */
public static function handle() {
if ( is_user_logged_in() ) {
wp_safe_redirect( admin_url() );
exit;
}
$errors = new WP_Error();
if ( 'POST' === strtoupper( isset( $_SERVER['REQUEST_METHOD'] ) ? sanitize_text_field( wp_unslash( $_SERVER['REQUEST_METHOD'] ) ) : 'GET' ) ) {
$result = self::process();
if ( is_wp_error( $result ) ) {
$errors = $result;
} else {
// Straight in. There is nothing left to confirm, so making
// someone sign a second time to start their session would be
// ceremony, not security.
wp_set_current_user( $result );
wp_set_auth_cookie( $result, false );
do_action( 'wp_login', get_userdata( $result )->user_login, get_userdata( $result ) );
wp_safe_redirect( apply_filters( 'sirius_press_after_register_redirect', admin_url(), $result ) );
exit;
}
}
self::render( $errors );
exit;
}
/**
* @return int|WP_Error User ID.
*/
private static function process() {
if ( ! SP_Settings::open_registration() ) {
return new WP_Error( 'sirius_closed', __( 'This site is not accepting new accounts.', 'sirius-press' ) );
}
$limited = SPA_Challenge::check_rate_limit( 'register', 10, 900 );
if ( is_wp_error( $limited ) ) {
return $limited;
}
// phpcs:disable WordPress.Security.NonceVerification.Missing -- the signed challenge is the anti-forgery proof.
$nonce = isset( $_POST['sirius_nonce'] ) ? sanitize_text_field( wp_unslash( $_POST['sirius_nonce'] ) ) : '';
$signature = isset( $_POST['sirius_signature'] ) ? sanitize_text_field( wp_unslash( $_POST['sirius_signature'] ) ) : '';
$login = isset( $_POST['user_login'] ) ? sanitize_user( wp_unslash( $_POST['user_login'] ), true ) : '';
$claimed = isset( $_POST['sirius_address'] ) ? sanitize_text_field( wp_unslash( $_POST['sirius_address'] ) ) : '';
// phpcs:enable WordPress.Security.NonceVerification.Missing
if ( '' === $signature || '' === $nonce ) {
return new WP_Error( 'sirius_missing', __( 'Sign the text above before submitting.', 'sirius-press' ) );
}
/*
* The claimed address is required here, unlike at sign-in. Recovering
* a key from a signature always succeeds, so without something to
* compare against, a signature over the wrong text would create an
* account bound to an address the registrant cannot sign for — and
* they would only find out the next time they tried to get in.
*/
if ( '' === $claimed ) {
return new WP_Error(
'sirius_missing_address',
__( 'Tell us which address you signed with, so the signature can be checked against it.', 'sirius-press' )
);
}
$address = SPA_Challenge::verify( $nonce, $signature, SPA_Challenge::PURPOSE_REGISTER, $claimed );
if ( is_wp_error( $address ) ) {
return $address;
}
$existing = SP_Identity::user_by_address( $address );
if ( $existing ) {
return new WP_Error(
'sirius_exists',
sprintf(
/* translators: %s: login URL. */
__( 'That wallet already has an account here. <a href="%s">Sign in</a> instead.', 'sirius-press' ),
esc_url( wp_login_url() )
)
);
}
if ( '' !== $login && username_exists( $login ) ) {
return new WP_Error( 'sirius_username_taken', __( 'That username is taken. Pick another.', 'sirius-press' ) );
}
return SP_Identity::create_user( $address, $login );
}
private static function render( WP_Error $errors ) {
$nonce = SPA_Challenge::issue();
$message = SPA_Challenge::message( $nonce, SPA_Challenge::PURPOSE_REGISTER );
$open = SP_Settings::open_registration();
login_header(
__( 'Create an account', 'sirius-press' ),
'',
$errors
);
SPA_Login::print_config();
?>
<form name="siriusregisterform" id="siriusregisterform" action="<?php echo esc_url( self::url() ); ?>" method="post">
<?php if ( ! $open ) : ?>
<p><?php esc_html_e( 'This site is not accepting new accounts right now.', 'sirius-press' ); ?></p>
<?php else : ?>
<p>
<label for="user_login"><?php esc_html_e( 'Username (optional)', 'sirius-press' ); ?></label>
<input type="text" name="user_login" id="user_login" class="input" value="" size="20"
autocapitalize="off" autocomplete="username" />
</p>
<p class="description sirius-hint">
<?php esc_html_e( 'Leave blank and one is made from your address. There is no email field, and there will not be a confirmation link — the signature below is the confirmation.', 'sirius-press' ); ?>
</p>
<?php SPA_Login::render_signing_block( $nonce, $message, SPA_Challenge::PURPOSE_REGISTER, __( 'Create account', 'sirius-press' ) ); ?>
<p class="submit">
<input type="submit" name="wp-submit" id="wp-submit" class="button button-primary button-large"
value="<?php esc_attr_e( 'Create account', 'sirius-press' ); ?>" />
</p>
<?php endif; ?>
</form>
<p id="nav">
<a href="<?php echo esc_url( wp_login_url() ); ?>"><?php esc_html_e( '← Sign in', 'sirius-press' ); ?></a>
</p>
<?php
login_footer();
}
}