sirius-press/plugins/sirius-press-core/sirius-press-core.php
Silent Mode ddf49a5523 fix(sirius-press): recovering a key is not the same as verifying a signature
Running the fork against a live WordPress found a real hole in registration,
and it is the kind that only shows up when you actually try it.

ECDSA public-key recovery always succeeds. Given any well-formed signature
and any digest it returns a key — just not the signer's, unless the digest is
the one that was signed. The auth flow leaned on that as if a wrong message
would fail. It does not; it quietly yields a stranger's address.

At sign-in this was harmless, because the wrong address matches no account
and the attempt fails. Registration and wallet-linking were another matter:
both took the recovered address and bound it to an account, so a signature
over slightly different text — a challenge copied without its blank line, a
wallet that rewrote the text, a login signature replayed at the registration
form — created an account keyed to an address nobody could sign for. The
person would see "success" and discover the truth the next time they tried to
get in. Wallet-linking was worse still: it would move an existing account onto
a dead address and lock its owner out of their own site.

Both paths now require the address the signer claims and compare it to the
recovered one, which is what verification actually means. Sign-in accepts the
claim when the page sends it and uses it to turn "no account uses that wallet"
into the more useful "that signature is not over the text we asked for".

Also from running it:

URL rewriting mangled every link on a site whose URL carries a port. The
protocol-relative pass matched inside absolute URLs and gave each one a second
scheme, and matching the host without its port left the port stranded as
`//host:8760:8760/`. Local and staging installs would have exported a site of
broken links.

Plain permalinks silently collapse an entire site onto one exported file,
because every post's URL is `/?p=N` and its path is `/`. The queue looks
healthy the whole time. The Publishing screen now says so.

Translations loaded on `plugins_loaded`, which WordPress 6.7 warns about on
every request — the kind of noise that trains people to stop reading logs.

And one deletion: an `is_email()` filter written on the assumption that
WordPress rejects `.invalid` addresses. It does not — `is_email()` validates
syntax, not whether a domain could exist — so the filter never fired. A filter
that appears to relax a rule but does not is worse than no filter, because
someone later reasons from it. The documentation made the same claim and has
been corrected.

Verification added rather than asserted: tests/live.mjs drives a real instance
over HTTP (40 checks), and tests/mock-gateway.mjs answers uploads with the
signature check transcribed from the gateway's own source, so the publishing
path can be exercised without a registered name.
2026-09-21 02:35:32 +02:00

145 lines
4.2 KiB
PHP

<?php
/**
* Plugin Name: Sirius Press Core
* Plugin URI: https://code.silentmode.st/silentmode/sirius-press
* Description: Wallet identity, gateway publishing and the in-app inbox that the rest of Sirius Press is built on.
* Version: 0.1.0
* Requires at least: 6.5
* Requires PHP: 7.4
* Author: Silent Mode
* Author URI: https://silentmode.st
* License: GPL-2.0-or-later
* License URI: https://www.gnu.org/licenses/gpl-2.0.html
* Text Domain: sirius-press
*
* @package SiriusPress
*/
defined( 'ABSPATH' ) || exit;
define( 'SIRIUS_PRESS_VERSION', '0.1.0' );
define( 'SIRIUS_PRESS_CORE_FILE', __FILE__ );
define( 'SIRIUS_PRESS_CORE_DIR', plugin_dir_path( __FILE__ ) );
define( 'SIRIUS_PRESS_CORE_URL', plugin_dir_url( __FILE__ ) );
foreach (
array(
'class-sp-bn',
'class-sp-secp256k1',
'class-sp-cashaddr',
'class-sp-hd',
'class-sp-message',
'class-sp-settings',
'class-sp-gateway',
'class-sp-identity',
'class-sp-inbox',
'class-sp-admin',
) as $sp_class
) {
require_once SIRIUS_PRESS_CORE_DIR . 'includes/' . $sp_class . '.php';
}
/**
* The function this whole fork turns on.
*
* Core calls `is_email()` in a dozen places to decide whether a string is a
* usable identity. Sirius Press answers the same question about a different
* kind of string, and the core patches in `patches/` swap the call rather
* than changing what `is_email()` itself means — plugins still need the real
* `is_email()` for contact forms and newsletters.
*
* @param string $value
* @return bool
*/
function is_cashaddr( $value ) {
return SP_CashAddr::is_valid( $value );
}
/**
* The address that identifies a user, or '' — the `user_email` of this fork.
*
* @param int|WP_User|null $user Defaults to the current user.
*/
function sirius_press_address( $user = null ) {
if ( null === $user ) {
$user = get_current_user_id();
}
$id = $user instanceof WP_User ? $user->ID : (int) $user;
return $id ? SP_Identity::address_of( $id ) : '';
}
/**
* Whether this installation can do wallet cryptography at all.
*
* Checked on activation and shown as an admin notice rather than left to
* surface as a fatal during someone's first login attempt.
*
* @return string '' when fine, otherwise what is missing.
*/
function sirius_press_requirements_problem() {
if ( ! SP_BN::available() ) {
return __( 'Sirius Press needs either the GMP or the BCMath PHP extension to verify wallet signatures. Ask your host to enable one — GMP is much faster.', 'sirius-press' );
}
if ( PHP_INT_SIZE < 8 ) {
return __( 'Sirius Press needs 64-bit PHP. Address checksums cannot be computed on a 32-bit build.', 'sirius-press' );
}
if ( ! function_exists( 'openssl_encrypt' ) ) {
return __( 'Sirius Press needs the OpenSSL PHP extension to store a publishing key safely.', 'sirius-press' );
}
return '';
}
register_activation_hook(
__FILE__,
function () {
SP_Inbox::install();
}
);
add_action(
'plugins_loaded',
function () {
if ( (int) get_option( 'sirius_press_inbox_version', 0 ) < SP_Inbox::VERSION ) {
SP_Inbox::install();
}
SP_Identity::hooks();
SP_Inbox::hooks();
SP_Admin::hooks();
}
);
/*
* Translations load on `init`, not `plugins_loaded`. WordPress 6.7 started
* warning about the earlier hook because the locale is not settled yet, and a
* notice on every request is the kind of thing that trains people to ignore
* their logs.
*/
add_action(
'init',
function () {
load_plugin_textdomain( 'sirius-press', false, dirname( plugin_basename( SIRIUS_PRESS_CORE_FILE ) ) . '/languages' );
}
);
add_action(
'admin_notices',
function () {
if ( ! current_user_can( 'manage_options' ) ) {
return;
}
$problem = sirius_press_requirements_problem();
if ( '' !== $problem ) {
printf( '<div class="notice notice-error"><p>%s</p></div>', esc_html( $problem ) );
return;
}
if ( ! SP_Settings::is_configured() ) {
printf(
'<div class="notice notice-warning"><p>%s <a href="%s">%s</a></p></div>',
esc_html__( 'Sirius Press does not know which BCNR name this site publishes under yet.', 'sirius-press' ),
esc_url( admin_url( 'admin.php?page=sirius-press' ) ),
esc_html__( 'Set it now', 'sirius-press' )
);
}
}
);