silentmode/theseus
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(theseus/settings): Performance/Privacy/Extensions sections were unreachable

Browse source 
The sections array in showSection() still listed 'naming' — the id I
deleted when Registries got folded into General in 0.3.21. Clicking
Performance / Privacy / Extensions in the sidebar looked up
getElementById('naming'), got null, and threw a TypeError setting
.hidden on it. The loop crashed before the target section was
un-hidden, so nothing appeared to happen — the currently-shown
section stayed visible and the click looked like a no-op.

One-line fix: drop 'naming' from the sections array. Also documented
why it's absent so no one puts it back.
This commit is contained in:
Local Dev 2026-09-08 02:23:27 +02:00
parent 76ab4e222a
commit 8943000ec5
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
settings.html
View file

@ -560,7 +560,11 @@
<script>
const C = window.cfg;
// sidebar navigation
const sections = ["general", "search", "passwords", "naming", "performance", "privacy", "addons"];
// "naming" is intentionally absent: the Registries section was folded
// into General in 0.3.21. Leaving the id in this list threw a
// TypeError inside showSection (getElementById("naming") → null),
// which broke every click after General/Search/Passwords.
const sections = ["general", "search", "passwords", "performance", "privacy", "addons"];
function showSection(sec) {
if (!sections.includes(sec)) return;
document.querySelectorAll(".side a").forEach((x) => x.classList.toggle("active", x.dataset.sec === sec));