silentmode/theseus
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(theseus/updater): re-add --force-run so Theseus auto-relaunches after silent install

Browse source 
install-update-now was spawning setup with ['/S'] alone since the
0.3.31 rewrite. That installs correctly (E2E-proven multiple times
this week) but leaves the user without a running browser after the
install completes — the setup exits, and the user has to click the
Start-menu shortcut to get Theseus back.

--force-run is electron-builder's NSIS convention for 'start the app
when the install finishes'; it makes the whole update feel like a
seamless in-place restart. --updated stays out (was proven not to
affect the install itself on our config).

Reported by user 2026-09-09 after 0.3.37 → 0.3.39 auto-update ran
cleanly but silently, with no post-install relaunch.
This commit is contained in:
Local Dev 2026-09-09 00:58:26 +02:00
parent a188aa49d2
commit e0c829dd10
2 changed files with 14 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
main.js
View file

@ -3232,15 +3232,22 @@ ipcMain.handle("recheck-update", async () => {
return { updateAvailable, currentVersion: app.getVersion() }; return { updateAvailable, currentVersion: app.getVersion() };
}); });
// One-click "Install & restart". Requires the silent pre-fetch to have // One-click "Install & restart". Requires the silent pre-fetch to have
// finished (updateDownloadState === "ready"). Launches the setup with /S // finished (updateDownloadState === "ready"). Launches the setup with
// (skips the wizard; our nsis/installer.nsh's Ariadne prompt is bypassed // /S (silent, skips the wizard) and --force-run (electron-builder's NSIS
// too on upgrades because the Ariadne registry key is already present), // convention for "start the app when the install finishes"), then quits
// then quits Theseus so the installer can overwrite it. When the installer // Theseus so the installer can overwrite it. The user sees the browser
// finishes, the user re-launches Theseus and lands on the new version. // disappear for a couple of seconds and come back on the new version —
// no manual relaunch needed. Verified E2E on 0.3.33 → 0.3.34 in the
// 2026-09-08 session; the 0.3.37 → 0.3.39 update ran WITHOUT --force-run
// (the flag was dropped in the 0.3.31 rewrite once it was clear /S alone
// installs correctly) and the user reported the missing relaunch — this
// commit puts --force-run back on so the auto-restart is part of the
// standard flow again. --updated stays out: the earlier E2E showed it
// wasn't load-bearing correctness for our NSIS config.
ipcMain.handle("install-update-now", () => { ipcMain.handle("install-update-now", () => {
if (updateDownloadState !== "ready" || !updateDownloadPath) return false; if (updateDownloadState !== "ready" || !updateDownloadPath) return false;
try { try {
const p = spawn(updateDownloadPath, ["/S"], { detached: true, stdio: "ignore" }); const p = spawn(updateDownloadPath, ["/S", "--force-run"], { detached: true, stdio: "ignore" });
p.unref(); p.unref();
} catch (e) { console.warn("update spawn failed:", e?.message); return false; } } catch (e) { console.warn("update spawn failed:", e?.message); return false; }
// Give the child a moment to inherit our arguments before we exit. // Give the child a moment to inherit our arguments before we exit.

2
package.json
View file

@ -1,6 +1,6 @@
{ {
"name": "theseus-navigator", "name": "theseus-navigator",
"version": "0.3.39", "version": "0.3.40",
"description": "Theseus Navigator — a browser that follows the thread. By Silent Mode, a Deviant project.", "description": "Theseus Navigator — a browser that follows the thread. By Silent Mode, a Deviant project.",
"author": "Silent Mode", "author": "Silent Mode",
"main": "main.js", "main": "main.js",